Repository navigation
Marketplace API - Offer Details endpoint - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Marketplace
offer_detailsmethod in both clients, replacing the stub.PriceCharting.offer_details(offer_id)andAsyncPriceCharting.offer_details(offer_id)send aGETto/api/offer-detailswithoffer-idand return anOfferDetailsResponse.offer_idis stripped, and an empty or whitespace-only value raisesParameterErrorbefore any request is sent, the same wayproducts(q)handlesq.docs/index.md, and the implementation status line inREADME.mdand the docs index now listsoffer_details.Type of Change
Feature
Checklist
just lintpassesjust testpassesREADME.md,docs/,CLAUDE.md)